TECH: (Silinsky) add dark mode screenshots support #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReCursia
requested review from
matzuk,
AzamatCherchesov,
eakurnikov,
RuslanMingaliev and
Nikitae57
as code owners
|
|
Nikitae57
requested changes
Jun 2, 2023
| import org.junit.runner.Description | ||
| import org.junit.runners.model.Statement | ||
|
|
||
| class ThemeRule internal constructor( |
There was a problem hiding this comment.
I would narrow down the name to tell user that this rule is used to toggle dark mode, not the whole theme
| import org.junit.runners.model.Statement | ||
|
|
||
| class ThemeRule internal constructor( | ||
| private val changeAppTheme: Boolean, |
| base.evaluate() | ||
| } | ||
| } finally { | ||
| AppCompatDelegate.setDefaultNightMode(AppCompatDelegate.MODE_NIGHT_FOLLOW_SYSTEM) |
There was a problem hiding this comment.
Would be better to save preferences before test and restore it after instead of setting "follow system" unconditionally
There was a problem hiding this comment.
I've changed to use UNSPECIFIED, this is default value and also used to "reset" chosen night mode in app
ReCursia
changed the title
Nikitae57
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502