Add AGP 4.1 support #305
Merged
Add AGP 4.1 support #305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin-bader
commented
Jul 7, 2020
| @@ -41,41 +44,6 @@ final class DexMethodCountPluginSpec extends Specification { | |||
| manifestFile.write(MANIFEST_FILE_TEXT) | |||
| } | |||
|
|
|||
| def 'unsupported project project'() { | |||
There was a problem hiding this comment.
Removed because the AGP 4.1 implementation doesn't have this constraint, and in our current test setup that's the plugin version used in these tests.
When #304 lands, we should re-add this check for AGP 4.0 and below.
| @@ -1,5 +1,5 @@ | |||
| GROUP=com.getkeepsafe.dexcount | |||
| VERSION_NAME=1.0.4-SNAPSHOT | |||
| VERSION_NAME=2.0.0-SNAPSHOT | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This absurdly-large PR adds essentially a brand-new plugin implementation using the new APIs introduced in AGP 4.1.0. For various reasons this requires breaking back-compat in terms of the names and locations of output files on older AGP versions. (tl;dr: not possible to replicate the exact layout in the new API, and it's better to have a consistent format rather than vary it based on AGP version).
Fixes #301