Detect AAR minSdkVersion and pass it to dx #311
Conversation
| var tempFile: File? = null | ||
|
|
||
| for (entry in entries) { | ||
| if (entry.name == "AndroidManifest.xml") { |
There was a problem hiding this comment.
Correct me if I'm wrong, but this would only work if the minSdk is defined in the manifest rather than in the build.gradle(.kts) where it is often defined, right?
There was a problem hiding this comment.
Build files (build.gradle and build.gradle.kts) are used to assemble an .aar archive, but are not included in it. The values you define in those build files are placed into the manifest file, where we can reliably read them.
CI is failing here because evidently, the version of dx used in CI doesn't have the --min-sdk-version option, so now I need to figure out when that flag was added, and conditionally use that option only if it exists.
There was a problem hiding this comment.
If you doubt this, check our integration tests. In integration/lib/build.gradle you'll certainly find the minSdkVersion defined there, and not in ./src/main/AndroidManifest.xml.
There was a problem hiding this comment.
Ah, excellent point - I'm not terribly used to working with pre-built archives so I overlooked that. I'll take a look at the new build you published and see if it works. Thanks for being so quick to put in this fix!
This is such a hack, but then so is AAR method counting so whatevs
Fixes #310