Add API endpoints to add remove tap temp sensors #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patfreeman
reviewed
May 12, 2020
pykeg/backend/backends.py
Outdated
Comment on lines
665
to
670
| if old_thermo: | ||
| tap.temperature_sensor = None | ||
| tap.save() | ||
| if new_thermo: | ||
| tap.temperature_sensor = new_thermo | ||
| tap.save() |
There was a problem hiding this comment.
I'd think something like this would be cleaner:
if new_thermo:
tap.temperature_sensor = new_thermo
else:
tap.temperature_sensor = None
tap.save()
Unless the tap needs to be saved without a thermo before it can be saves with a thermo.
|
Also needs |
|
Thanks @patfreeman, I’ll test the simplified code. I did something similar and ran into an issue with it not saving, but going to give this a try. For the black formatting good catch, missed that in the developer guide. |
black formatting
|
thanks! adding a link to the android change so github does its thing & linkifies it over there too: Kegbot/kegbot-android#120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new API endpoints to allow a user to add/remove a thermo sensor from a tap.
Connect: /api/taps/[tap_id]/connect-thermo (from x-urlencoded form "thermo": [thermo_id])
Disconnect: /api/taps/[tap_id]/disconnect-thermo
This will allows users to select the thermo sensor from the Android app similar to selecting the flow sensor and tap toggle. I have a PR on the Android side to add this selection to the tap settings.