Update to django 3.2 #423
Merged
Update to django 3.2 #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required in Django 4.0
Prior url definitions installed routes with a `r".../?$"` path regex, meaning the same view would be served regardless of trailing slash presence. With the previous change, we use `path(..)` in most places, which provides a convenient shorthand for declaring path parameters (`<int:id>` etc). However we can no longer specify a regex in that shorthand. This creates a new problem: Routes that formerly got a direct response, for example `GET /api/events/`, now get a 404. This can break existing API clients, of which I'm not sure how many there are, nor do I know their slash-or-not behaviors. To get around this we install a new middleware, `PathRewriteMiddleware`, which rewrites the internal path -- without redirecting -- when a trailing slash is found. We only activate this for `/api/` routes since browsers will deal with 301s as needed just fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.