Please integrate into Base Julia!!! #8

StefanKarpinski · 2014-01-09T23:26:51Z

I know this must be useable because you've been using it forever. Can we also have it please? If you outline what needs to be done, I can help.

cc: @carlobaldassi, @JeffBezanson, @ViralBShah

ViralBShah · 2014-01-10T02:23:58Z

+Inf

ivarne · 2014-01-10T07:27:57Z

I have the impression that many developers want to contribute to the REPL, but we hold them back, because we say we will get rid of readline.

+BigFloat(Inf)

StefanKarpinski · 2014-01-10T07:57:38Z

I have that impression as well.

with_bigfloat_precision(1024) do
  big(Inf)
end

Keno · 2014-01-10T13:18:38Z

Ok, fine, I get it. Let's get this done.

StefanKarpinski · 2014-01-10T18:57:17Z

:D

Keno · 2014-01-11T02:18:11Z

Alright, first order of business is to get people to try this and make sure bugs are getting fixed. To that end, I added the script needed to run the repl from the command line. To try it out, instead of running julia, run julia ~/.julia/REPL/scripts/repl.jl. At this point, my workflow is fairly well tested, but I'm sure other people are doing things I usually don't, so there'll be bugs.

ViralBShah · 2014-01-11T05:22:00Z

I had to checkout the master of TERM.jl and Readline.jl manually first. Then, I get a whole bunch of ambiguity warnings and the banner_color error. If I comment out that line, I get this error:

ERROR: uv_error not defined
 in size at /Users/viral/.julia/Terminals/src/Terminals.jl:453
 in refreshMultiLine at /Users/viral/.julia/Readline/src/Readline.jl:160
 in activate at /Users/viral/.julia/Readline/src/Readline.jl:859
 in activate at /Users/viral/.julia/Readline/src/Readline.jl:864
 in prompt! at /Users/viral/.julia/Readline/src/Readline.jl:938
 in run_interface at /Users/viral/.julia/Readline/src/Readline.jl:923
 in run_repl at /Users/viral/.julia/REPL/src/REPL.jl:473
 in anonymous at no file:34
while loading /Users/viral/.julia/REPL/scripts/repl.jl, in expression starting on line 9

ViralBShah · 2014-01-11T05:23:27Z

Ok, I had to also update Terminals to master. After that, no errors or ambiguity warnings.

ViralBShah · 2014-01-11T05:42:59Z

That could easily update a lot of packages to master, unknowingly. Perhaps a warning along the lines would be good to have though, so that the user can decide.

Keno · 2014-01-11T22:45:04Z

All reported bugs fixed. Keep them coming.

StefanKarpinski · 2014-01-15T16:41:17Z

My feeling is that this is pretty close to being ready for integration into Base. There's a few more bugs to iron out, but it already serves as a great drop-in replacement for the old REPL for me.

StefanKarpinski · 2014-01-16T06:11:08Z

Ok, there's no obvious issues left. I say we merge this puppy into Base. What's the procedure?

ViralBShah · 2014-01-17T06:39:58Z

Currently, any exception makes the script quit. I guess, we just need to get to a point where this is handled well, and it doesn't quit.

ivarne · 2014-01-17T07:04:29Z

We do not need to make the new REPL default, to integrate it to Base. It can live alongside the old for a while.

nolta · 2014-03-23T00:19:27Z

I hope i'm not stepping on anyone's toes, but i took a crack at this: https://github.com/JuliaLang/julia/compare/mn;newrepl

Keno · 2014-03-23T00:21:03Z

My toes are too busy with school work to be stepped on by anybody ;)

jariou · 2014-03-27T03:00:04Z

I followed instructions here: #34

I am on Windows 7. Here is what I get

C:\Users\Jacques>C:\Julia\Julia_0.3.0-prerelease\bin\julia.exe C:/Users/Jacques/.julia/v0.3/REPL/scripts/repl.jl
Warning: redefining constant CPU_CORES
ERROR: spawn: no such file or directory (ENOENT)
in _jl_spawn at process.jl:212
while loading C:\Users\Jacques.julia\v0.3\REPL\scripts\repl.jl, in expression s
tarting on line 8

blas_num_threads=4

C:\Users\Jacques>

ivarne · 2014-03-27T06:46:59Z

What version of julia are you using? I think the CPU_CORES warning was fixed a while back, and it is very rewarding to debug issues that might already have been fixed. Can you try to update if your nightly release is more than a week old?

jariou · 2014-03-27T12:19:24Z

It is definitely more than a few weeks old. I don't build it locally, it is an install from perhaps 6 or 8 weeks ago. If you can point me to instructions to update an installed version to the latest and greatest binaries and supporting files, I'll be happy to give feedback on the issue.

ivarne · 2014-03-27T12:53:58Z

I would guess that it would work to follow the instructions on julialang.org/downloads. I don't have access to a windows computer, so I have not tried. @ihnorton also just published prebundled version JuliaLang/julia#6270 (comment), that you might give a try.

jariou · 2014-03-27T14:00:53Z

Thanks,

I'll give it a try tonight and report.

Sent from my Verizon Wireless 4G LTE smartphone

-------- Original message --------
From: Ivar Nesje [email protected]
Date:03/27/2014 8:53 AM (GMT-05:00)
To: "loladiro/REPL.jl" [email protected]
Cc: Jacques Rioux [email protected]
Subject: Re: [REPL.jl] Please integrate into Base Julia!!! (#8)

I would guess that it would work to follow the instructions on julialang.org/downloads. I don't have access to a windows computer, so I have not tried. @ihnorton also just published prebundled version JuliaLang/julia#6270 (comment), that you might give a try.

—
Reply to this email directly or view it on GitHub.

jariou · 2014-03-27T22:58:26Z

I downloaded @ihnorton's prebundled version and I still have problems. See beloaw, first a launch of julia-basic with Pkg.update() within that session. Then I exit and launch with REPL.jl and get error:
ERROR: spawn: no such file or directory (ENOENT)
in _jl_spawn at process.jl:212
while loading c:\users\Jacques.julia\v0.3\REPL\scripts\repl.jl, in expression s
tarting on line 8

blas_num_threads=4

See the two complete launches below

C:\Julia\JuliaRepl\Julia 0.3.0-prerelease\bin>julia-basic
_
_ _ ()_ | A fresh approach to technical computing
() | () () | Documentation: http://docs.julialang.org
_ _ | | __ _ | Type "help()" to list help topics
| | | | | | |/ ` | |
| | || | | | (| | | Version 0.3.0-prerelease+2175 (2014-03-26 21:52 UTC)
/ |_'|||__'| | mn/newrepl/fd19a97* (fork: 10 commits, 1 day)
|__/ | x86_64-w64-mingw32

julia> Pkg.update()
INFO: Updating METADATA...
INFO: Updating cache of Color...
INFO: Updating cache of Images...
INFO: Updating Readline...
INFO: Updating Terminals...
INFO: Updating REPLCompletions...
INFO: Computing changes...
INFO: Upgrading Color: v0.2.8 => v0.2.9
INFO: Upgrading DataArrays: v0.1.3 => v0.1.4
INFO: Upgrading Images: v0.2.32 => v0.2.34
INFO: Building Images

julia> exit()
blas_num_threads=4

C:\Julia\JuliaRepl\Julia 0.3.0-prerelease\bin>julia-basic c:/users/Jacques/.juli
a/v0.3/REPL/scripts/repl.jl
ERROR: spawn: no such file or directory (ENOENT)
in _jl_spawn at process.jl:212
while loading c:\users\Jacques.julia\v0.3\REPL\scripts\repl.jl, in expression s
tarting on line 8

blas_num_threads=4

C:\Julia\JuliaRepl\Julia 0.3.0-prerelease\bin>

nolta · 2014-03-28T00:46:01Z

@jariou ihnorton's prebundled version already includes REPL.jl, so you don't need to run scripts\repl.jl.

StefanKarpinski · 2014-03-28T00:47:07Z

Yes, in this version, you just run julia normally you get the new REPL.

jariou · 2014-03-28T02:02:54Z

Ah ok.

I get it now. Sorry for the bother. It looks good. Anything I can do to help?

nolta · 2014-03-28T04:43:45Z

Just try it out, and let us know if you find any problems. Thanks!

waldyrious · 2014-03-30T01:10:52Z

For reference: This is now closed because JuliaLang/julia#6270 has been merged.

carlobaldassi mentioned this issue Jan 10, 2014

Add file completion to the REPL JuliaLang/julia#5343

Merged

Keno closed this as completed Mar 30, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Please integrate into Base Julia!!! #8

Please integrate into Base Julia!!! #8

StefanKarpinski commented Jan 9, 2014

ViralBShah commented Jan 10, 2014

ivarne commented Jan 10, 2014

StefanKarpinski commented Jan 10, 2014

Keno commented Jan 10, 2014

StefanKarpinski commented Jan 10, 2014

Keno commented Jan 11, 2014

ViralBShah commented Jan 11, 2014

ViralBShah commented Jan 11, 2014

ViralBShah commented Jan 11, 2014

Keno commented Jan 11, 2014

StefanKarpinski commented Jan 15, 2014

StefanKarpinski commented Jan 16, 2014

ViralBShah commented Jan 17, 2014

ivarne commented Jan 17, 2014

nolta commented Mar 23, 2014

Keno commented Mar 23, 2014

jariou commented Mar 27, 2014

ivarne commented Mar 27, 2014

jariou commented Mar 27, 2014

ivarne commented Mar 27, 2014

jariou commented Mar 27, 2014

jariou commented Mar 27, 2014

nolta commented Mar 28, 2014

StefanKarpinski commented Mar 28, 2014

jariou commented Mar 28, 2014

nolta commented Mar 28, 2014

waldyrious commented Mar 30, 2014

Please integrate into Base Julia!!! #8

Please integrate into Base Julia!!! #8

Comments

StefanKarpinski commented Jan 9, 2014

ViralBShah commented Jan 10, 2014

ivarne commented Jan 10, 2014

StefanKarpinski commented Jan 10, 2014

Keno commented Jan 10, 2014

StefanKarpinski commented Jan 10, 2014

Keno commented Jan 11, 2014

ViralBShah commented Jan 11, 2014

ViralBShah commented Jan 11, 2014

ViralBShah commented Jan 11, 2014

Keno commented Jan 11, 2014

StefanKarpinski commented Jan 15, 2014

StefanKarpinski commented Jan 16, 2014

ViralBShah commented Jan 17, 2014

ivarne commented Jan 17, 2014

nolta commented Mar 23, 2014

Keno commented Mar 23, 2014

jariou commented Mar 27, 2014

ivarne commented Mar 27, 2014

jariou commented Mar 27, 2014

ivarne commented Mar 27, 2014

jariou commented Mar 27, 2014

jariou commented Mar 27, 2014

See the two complete launches below

nolta commented Mar 28, 2014

StefanKarpinski commented Mar 28, 2014

jariou commented Mar 28, 2014

nolta commented Mar 28, 2014

waldyrious commented Mar 30, 2014