[refactor] 랭크 스케줄러 수정 #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* 랭크 스케줄러로 인해 답변이 (수정됨) 으로 바뀌는 현상 -> 엔티티 타지 않고 바로 repository 로 update
mooncw
reviewed
Mar 27, 2024
|
|
||
| alertService.sendToBroker(alertDtoMapper.from(AlertDto.RankAnswerAlert.of(question, answer, rank))); | ||
| answerRepository.updateAnswerRank(rank, answer.getId()); |
There was a problem hiding this comment.
레포지토리 메서드를 바로 호출하기 보단 answerStore 사용 가능하십니까? ㅎㅎ
RossKWSang
reviewed
Mar 27, 2024
Comment on lines
+31
to
+33
| @Modifying | ||
| @Query("UPDATE Answer a SET a.rank = :rank WHERE a.id = :answerId") | ||
| void updateAnswerRank(@Param("rank") Rank rank, @Param("answerId") Long answerId); |
There was a problem hiding this comment.
Answer 엔티티에 UpdateRank 방식으로 수정하는 방법은 생각해보셨나요?
There was a problem hiding this comment.
말씀해주신 방법이 (수정됨) 표시가 되어 위 방법을 적용했습니다.
There was a problem hiding this comment.
Answer 엔티티에 UpdateRank 방식으로 수정하는 방법은 생각해보셨나요?
이렇게 하면 답변 랭킹 산정 과정에서 modifiedDate가 변경되어 화면에서 수정됨이 뜨게 되는 문제가 있었습니다.
hodadako
reviewed
Mar 27, 2024
| @@ -24,6 +25,11 @@ public Answer store(Answer answer) { | |||
| return answerRepository.save(answer); | |||
| } | |||
|
|
|||
| @Override | |||
| public void upRank(Rank rank, Long answerId) { | |||
| answerRepository.updateAnswerRank(rank, answerId); | |||
RossKWSang
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR을 보내기 전에 확인해주세요!!
관련 이슈
close: #487
개요
상세 내용