Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] AOP 리팩터링 1차 #83

Merged
merged 3 commits into from
Jan 9, 2024
Merged

[refactor] AOP 리팩터링 1차 #83

merged 3 commits into from
Jan 9, 2024

Conversation

Hju95
Copy link
Collaborator

@Hju95 Hju95 commented Jan 9, 2024 •
edited
Loading

PR을 보내기 전에 확인해주세요!!

  • 컨벤션에 맞게 작성했습니다. 컨벤션 확인은 여기
  • 변경 사항에 대한 테스트를 했습니다.

관련 이슈

close: #16

개요

aop 리팩터링

상세 내용

  • 모든 컨트롤러, 서비스에 적용
  • 레파지토리는 제외
  • MDC 적용하여 트래킹 쉽게 만듬

@Hju95 Hju95 added the Refactor 코드 리팩토링 label Jan 9, 2024
@Hju95 Hju95 self-assigned this Jan 9, 2024
@cr-gpt CR.GPT
Copy link

cr-gpt bot commented Jan 9, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@Hju95 Hju95 changed the title [refactor] Aop 리팩터링 1차 [refactor] AOP 리팩터링 1차 Jan 9, 2024
hodadako
hodadako approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@hodadako hodadako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

mooncw
mooncw approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@mooncw mooncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅎㅎㅎㅎ....

@mooncw mooncw merged commit 541a3b7 into Kernel360:main Jan 9, 2024
1 check passed
@Hju95 Hju95 deleted the AOP리팩터링 branch January 19, 2024 01:51
mooncw added a commit that referenced this pull request Apr 5, 2024
@mooncw
Merge pull request #83 from Hju95/AOP리팩터링
7a7582e 
[refactor] AOP 리팩터링 1차
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooncw mooncw mooncw approved these changes

@hodadako hodadako hodadako approved these changes

@RossKWSang RossKWSang Awaiting requested review from RossKWSang RossKWSang is a code owner

Assignees

@Hju95 Hju95

Labels
Refactor 코드 리팩토링
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 필요한 로그를 추가하고, 전체 로그들을 파일로 남기는 기능 개발
3 participants
@Hju95 @hodadako @mooncw