Skip to content

Commit

Permalink
Review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
benjaminjkraft committed Sep 9, 2021
1 parent b373a32 commit f3c3db8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
5 changes: 2 additions & 3 deletions generate/convert.go
Original file line number Diff line number Diff line change
Expand Up @@ -452,9 +452,8 @@ func (g *generator) convertInlineFragment(
}

// convertFragmentSpread converts a single GraphQL fragment-spread
// (`...MyFragment`) into a Go struct-field. It assumes that
// convertNamedFragment has already been called on the fragment-definition. If
// the fragment does not apply to this type, returns nil.
// (`...MyFragment`) into a Go struct-field. If the fragment does not apply to
// this type, returns nil.
//
// containingTypedef is as described in convertInlineFragment, above.
func (g *generator) convertFragmentSpread(
Expand Down
2 changes: 1 addition & 1 deletion generate/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func (typ *goStructType) WriteDefinition(w io.Writer, g *generator) error {
//
// For embedded fields (from fragments), mostly the JSON library would just
// do what we want, but there are two problems. First, if the embedded
// ype has its own UnmarshalJSON, naively that would be promoted to
// type has its own UnmarshalJSON, naively that would be promoted to
// become our UnmarshalJSON, which is no good. But we don't want to just
// hide that method and inline its fields, either; we need to call its
// UnmarshalJSON (on the same object we unmarshal into this struct).
Expand Down

0 comments on commit f3c3db8

Please sign in to comment.