Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🔥AUDIT🔥] Typo fix #100

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[🔥AUDIT🔥] Typo fix #100

merged 1 commit into from
Sep 16, 2021

Conversation

benjaminjkraft
Copy link
Collaborator

🖍 This is an audit! 🖍

Auditors: steve

@benjaminjkraft benjaminjkraft self-assigned this Sep 16, 2021
@benjaminjkraft benjaminjkraft merged commit 50b2f56 into main Sep 16, 2021
@benjaminjkraft benjaminjkraft deleted the benkraft.typofix branch September 16, 2021 16:11
@StevenACoffman
Copy link
Member

You're hilarious. :) I meant that only as an example. There's a bunch of others here: https://goreportcard.com/report/github.com/Khan/genqlient

genqlient/internal/testutil/cupaloy.go
Line 5: warning: exported var Cupaloy should have comment or be unexported (golint)
genqlient/internal/integration/server/server.go
Line 85: warning: exported function RunServer should have comment or be unexported (golint)
genqlient/generate/errors.go
Line 26: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
Line 53: warning: if block ends with a return statement, so drop this else and outdent its block (golint)
genqlient/generate/main.go
Line 39: warning: exported function Main should have comment or be unexported (golint)
genqlient/internal/lint/tools.go
Line 8: warning: a blank import should be only in a main or test package, or have a comment justifying it (golint)
genqlient/internal/testutil/types.go
Line 9: warning: exported type ID should have comment or be unexported (golint)
Line 11: warning: exported type Pokemon should have comment or be unexported (golint)
Line 16: warning: exported method Pokemon.Battle should have comment or be unexported (golint)
Line 20: warning: exported type MyContext should have comment or be unexported (golint)
Line 26: warning: exported function GetClientFromNowhere should have comment or be unexported (golint)
Line 27: warning: exported function GetClientFromContext should have comment or be unexported (golint)
Line 28: warning: exported function GetClientFromMyContext should have comment or be unexported (golint)
genqlient/example/caller.go
Line 22: warning: exported function Main should have comment or be unexported (golint)
genqlient/generate/config.go
Line 18: warning: exported type Config should have comment or be unexported (golint)
Line 148: warning: exported method Config.ValidateAndFillDefaults should have comment or be unexported (golint)
Line 177: warning: exported function ReadAndValidateConfig should have comment or be unexported (golint)
genqlient/generate/genqlient_directive.go
Line 89: warning: exported method GenqlientDirective.GetOmitempty should have comment or be unexported (golint)
Line 90: warning: exported method GenqlientDirective.GetPointer should have comment or be unexported (golint)

Copy link
Member

@StevenACoffman StevenACoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve this audit.

@benjaminjkraft
Copy link
Collaborator Author

Fixing only the one issue is intentional; see my comments on #96.

@StevenACoffman
Copy link
Member

Oh great. Thanks. Weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants