issue-link js-issue-link" data-error-text="Failed to load title" data-id="975000935" data-permission-text="Title is private" data-url="https://github.com/Khan/genqlient/issues/51" data-hovercard-type="pull_request" data-hovercard-url="/Khan/genqlient/pull/51/hovercard" href="https://github.com/Khan/genqlient/pull/51">#51, and I didn't think to update it there, but I think it benefits from similar treatment, for similar reasons. Specifically, the main change is to treat variables as another struct type we can generate, rather than handling them inline as a `map[string]interface{}`. Users still pass them the same way, but instead of putting them into a `map[string]interface{}` and JSONifying that, we generate a struct and put them there. This turns out to simplify things quite a lot, because we already have a lot of code to generate types. Notably, the omitempty code goes from a dozen lines to basically two, and fixes a bug (#43) in the process, because now that we have a struct, `json.Marshal` will do our work for us! (And, once we have syntax for it (#14), we'll be able to handle field-level omitempty basically for free.) More importantly, it will simplify custom marshalers (#38, forthcoming) significantly, since we do all that logic at the containing-struct level, but will need to apply it to arguments. It does require one breaking change, for folks implementing the `graphql.Client` API (rather than just calling `NewClient`): we now pass them variables as an `interface{}` rather than a `map[string]interface{}`. For most callers, including Khan/webapp, this is basically a one-line change to the signature of their `MakeRequest`. Issue: #38 Issue: #43 Test plan: make check Reviewers: marksandstrom, steve, jvoll, mahtab, adam, miguel

Commits

Commits on Sep 23, 2021

Refactor argument-handling to use a struct

Fix tests, unskip a test that now passes!

Set IsInput correctly (oesn't matter yet, but will soon)

Document second breaking change

Review comments