Sort operations to guarantee a stable order

[edigaryev]

Problem: currently when using a wildcard that covers multiple files in operations: YAML directive the generator emits functions in a non-stable ordering due to the use of map for storing file names:

genqlient/generate/parse.go

Lines 68 to 84 in e0accbd

	func expandFilenames(globs []string) ([]string, error) {
	uniqFilenames := make(map[string]bool, len(globs))
	for _, glob := range globs {
	matches, err := filepath.Glob(glob)
	if err != nil {
	return nil, errorf(nil, "can't expand file-glob %v: %v", glob, err)
	}
	for _, match := range matches {
	uniqFilenames[match] = true
	}
	}
	filenames := make([]string, 0, len(uniqFilenames))
	for filename := range uniqFilenames {
	filenames = append(filenames, filename)
	}
	return filenames, nil
	}

Solution: sort the operations before emitting them.

[csilvers]

Good catch! Change looks good to me. The only issue before merging is to make sure you've signed the CLA. Sadly I don't know the details of that. I'll try to figure out out after the holiday (probably Monday)

[csilvers]

Oh, one more thing: it looks like there's a failing test. Can you fix that up?

[benjaminjkraft]

Good idea -- matches what we do for the types they reference. Thanks!

The CLA is at https://www.khanacademy.org/r/cla. For the tests I think you'll just need to go generate ./... to rebuild the example and integration tests.

[edigaryev]

Oh, one more thing: it looks like there's a failing test. Can you fix that up?

Fixed a couple of tests failing locally, see b9c47e4 and 95c5403.

Not sure about the tests that run on CI, though.

[edigaryev]

For the tests I think you'll just need to go generate ./... to rebuild the example and integration tests.

See 6930225.

[edigaryev]

The CLA is at https://www.khanacademy.org/r/cla.

CLA sent.