Allow absolute paths in schema files. #192
Conversation
Thsi is useful for some out-of-tree testing I want to do. It's unfortunate (imo) that filepath.join doesn't have this behavior by default. Test plan: go test ./...
csilvers
requested review from
benjaminjkraft,
dnerdy and
StevenACoffman
as code owners
| // pathJoin is like filepath.Join but 1) it only takes two argsuments, | ||
| // and b) if the second argument is an absolute path the first argument | ||
| // is ignored (similar to how python's os.path.join() works). | ||
| func pathJoin(a, b string) string { |
There was a problem hiding this comment.
I would suggest a more accurate name such as func abs(basedir, path string) string {
This is then similar to the stdlib's filepath.Abs but allows you to specify the base directory instead of using the current working directory.
func Abs ¶
func Abs(path string) (string, error)
Abs returns an absolute representation of path. If the path is not absolute it will be joined with the current working directory to turn it into an absolute path. The absolute path name for a given file is not guaranteed to be unique. Abs calls Clean on the result.
There was a problem hiding this comment.
abs isn't very accurate because there's no requirement that a be an absolute path. I really see this as a "proper" path-join (and the default go implementation as not-proper). But ymmv.
There was a problem hiding this comment.
This is an unexported helper, so you do you.
There was a problem hiding this comment.
I agree the name isn't ideal, but I don't have a better idea, so I'm fine with this. (Closest thing I can think of in the stdlib is net/url.ResolveReference which I don't think is the greatest name either.)
generate/config.go
Outdated
| } | ||
| for i := range c.Operations { | ||
| c.Operations[i] = filepath.Join(baseDir, c.Operations[i]) | ||
| c.Operations[i] = pathJoin(baseDir, c.Operations[i]) | ||
| } | ||
| c.Generated = filepath.Join(baseDir, c.Generated) |
There was a problem hiding this comment.
May as well do Generated too!
| // pathJoin is like filepath.Join but 1) it only takes two argsuments, | ||
| // and b) if the second argument is an absolute path the first argument | ||
| // is ignored (similar to how python's os.path.join() works). | ||
| func pathJoin(a, b string) string { |
There was a problem hiding this comment.
I agree the name isn't ideal, but I don't have a better idea, so I'm fine with this. (Closest thing I can think of in the stdlib is net/url.ResolveReference which I don't think is the greatest name either.)
Thsi is useful for some out-of-tree testing I want to do. It's
unfortunate (imo) that filepath.join doesn't have this behavior by
default.
Test plan:
go test ./...
I have: