Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrectly formatted error string #213

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

breml
Copy link
Contributor

@breml breml commented Aug 4, 2022

Follow best practices from Go Review Comments:
https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Closes: #202

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@benjaminjkraft
Copy link
Collaborator

Thanks!

@benjaminjkraft benjaminjkraft merged commit c0510ff into Khan:main Aug 4, 2022
@breml breml deleted the fix-202 branch August 8, 2022 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lowercase the error massage, because go-staticcheck complains with ST1005
2 participants