Give a better error if package_bindings is a file #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entries under the new `package_bindings` field should be packages, but it's an easy mistake to put a file path instead (most of the other fields in `genqlient.yaml` are files). Due to some bizzare behavior from `go/packages` (described in #220), if you do that you get weird broken code that gives you no clue what is wrong. Instead, let's guess if what you gave us looks like a filename, and report a nice error if so. Test plan: crossed fingers
benjaminjkraft
requested review from
csilvers,
dnerdy and
StevenACoffman
as code owners
csilvers
approved these changes
Aug 15, 2022
|
I think in theory it's legal! As long as your package clause is still |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entries under the new
package_bindingsfield should be packages,but it's an easy mistake to put a file path instead (most of the other
fields in
genqlient.yamlare files). Due to some bizzare behavior fromgo/packages(described in #220), if you do that you get weird brokencode that gives you no clue what is wrong. Instead, let's guess if what
you gave us looks like a filename, and report a nice error if so.
Test plan: crossed fingers
I have: