Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the query constant to have an underscore in it. #241

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Rename the query constant to have an underscore in it. #241

merged 1 commit into from
Nov 22, 2022

Conversation

csilvers
Copy link
Member

We got reports of conflicts with the old constant-name and symbols that people were defining in their app.

I have:

  • Written a clear PR title and description (above)
  • Signed the Khan Academy CLA
  • Added tests covering my changes, if applicable
  • Included a link to the issue fixed, if applicable
  • Included documentation, for new features
  • Added an entry to the changelog

@csilvers
Rename the query constant to have an underscore in it.
3a8345a 
We got reports of conflicts with the old constant-name and symbols
that people were defining in their app.
@csilvers csilvers mentioned this pull request Nov 22, 2022
Merged
6 tasks
benjaminjkraft
benjaminjkraft approved these changes Nov 22, 2022
View reviewed changes
Copy link
Collaborator

@benjaminjkraft benjaminjkraft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, this is at least better. We can discuss a bit more before we cut a release.

@benjaminjkraft benjaminjkraft merged commit e322738 into main Nov 22, 2022
@benjaminjkraft benjaminjkraft deleted the better-constant branch November 22, 2022 22:12
@benjaminjkraft benjaminjkraft mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminjkraft benjaminjkraft benjaminjkraft approved these changes

@dnerdy dnerdy Awaiting requested review from dnerdy dnerdy is a code owner

@StevenACoffman StevenACoffman Awaiting requested review from StevenACoffman StevenACoffman is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csilvers @benjaminjkraft