Clean up example a little #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminjkraft
requested review from
aberkan,
dnerdy,
jvoll,
mahtabsabet and
MiguelCastillo
I realized: - it's simpler to avoid the usual `cmd` and just put it all in the same directory - we don't need schema.json since GitHub now posts a schema in SDL format Test plan: make lint example Reviewers: marksandstrom, jvoll, adam, miguel, mahtab
benjaminjkraft
force-pushed
the
benkraft.example
branch
from
26c780e to
6f81230
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I realized:
cmdand just put it all in the samedirectory
format
Test plan:
make lint example