Allow A8B8G8R8 formats. #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue #860.
Switches are generated by the KTX-Specification's generate_format_switches.rb. This is instead of updating the existing switches manually with newly allowed formats.
Add new workflow file to test build this target and remove mkvk checks from windows.yml and .travis.yml due to mkvk now needing a clone of the KTX-Specification repo.
Has been done by generating the source files from mkvkformatfiles which has been moved to ci_scripts as it no longer generates files just in the lib directory. Due to this vkformat_list.inl has been moved to tests/unittests which is where it is used.
|
Please review soon. I want to get this merged. |
aqnuep
approved these changes
Feb 23, 2024
KaperD
pushed a commit
to KaperD/KTX-Software
that referenced
this pull request
Feb 26, 2024
Fixes issue KhronosGroup#860. Updates the switches used by the the GL loader to those generated by `generate_format_switches.rb` in the KTX-Specification repo as a way to get them updated for these and some other recently added Vulkan formats. The glloader now loads the newly allowed formats. VkFormat declarations for Java and Python are now generated by `mkvkformatfiles` which has been moved to ci_scripts since it now generates files outside the `lib` directory. The unattractive alternative was to hand edit these files to add the newly allowed formats. CI testing of vkformat-related file generation (`mkvk`) has been moved to a dedicated GitHub workflow and removed from the main CI builds. This is because testing now requires a clone of the KTX-Specification repo due to the use of `generate_format_switches.rb`. The change to `createdfd.c` is to remove a duplicated line of code and is unrelated to the purpose of this PR. KhronosGroup/KTX-Software-CTS#19 removes the tests for these as prohibited and adds new tests for the formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #860.
Updates the switches used by the the GL loader to those generated by
generate_format_switches.rbin the KTX-Specification repo as a way to get them updated for these and some other recently added Vulkan formats. The glloader now loads the newly allowed formats.VkFormat declarations for Java and Python are now generated by
mkvkformatfileswhich has been moved to ci_scripts since it now generates files outside thelibdirectory. The alternative was to hand edit these files to add the newly allowed formats.CI testing of vkformat-related file generation (
mkvk) has been moved to a dedicated GitHub workflow and removed from the main CI builds. This is because testing now requires a clone of the KTX-Specification repo.The change to
createdfd.cis to remove a duplicated line of code and is unrelated to the purpose of this PR.KhronosGroup/KTX-Software-CTS#19 removes the tests for these as prohibited and adds new tests for the formats.