Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test plan for SYCL_KHR_GROUP_INTERFACE #1023

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

0x12CC
Copy link
Contributor

@0x12CC 0x12CC commented Jan 22, 2025

No description provided.

@gmlueck
Copy link
Contributor

gmlueck commented Jan 22, 2025

0x12CC requested review from gmlueck and https://github.com/orgs/KhronosGroup/teams/sycl-cts-reviewers as code owners 18 minutes ago

@Pennycook can you review this? I think you're closer to this API than me, so you'd do a better job reviewing the test plan.

@0x12CC
Copy link
Contributor Author

0x12CC commented Jan 22, 2025

I didn't include any of the C++ 23 member functions in this test plan since I don't have a working implementation of <mdspan>. Adding these tests shouldn't be much work but it's difficult to do without this header since I can't be sure the tests actually compile and run correctly.

@Pennycook
Copy link
Contributor

I didn't include any of the C++ 23 member functions in this test plan since I don't have a working implementation of <mdspan>. Adding these tests shouldn't be much work but it's difficult to do without this header since I can't be sure the tests actually compile and run correctly.

Could you use https://github.com/kokkos/mdspan? That's what I've used for mdspan experiments in the past.

@0x12CC
Copy link
Contributor Author

0x12CC commented Jan 22, 2025

I didn't include any of the C++ 23 member functions in this test plan since I don't have a working implementation of <mdspan>. Adding these tests shouldn't be much work but it's difficult to do without this header since I can't be sure the tests actually compile and run correctly.

Could you use https://github.com/kokkos/mdspan? That's what I've used for mdspan experiments in the past.

I'll try using this to add the missing test cases.

Copy link
Member

@keryell keryell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@Pennycook Pennycook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's here so far looks good to me. I've held off on approving to give @0x12CC a chance to experiment with kokkos/mdspan, as it would be nice to have the C++23 tests in place.

test_plans/khr/sycl_khr_group_interface.asciidoc Outdated Show resolved Hide resolved
@TApplencourt TApplencourt self-assigned this Jan 23, 2025
Signed-off-by: Michael Aziz <[email protected]>
@0x12CC
Copy link
Contributor Author

0x12CC commented Feb 10, 2025

@Pennycook, I've updated this test plan to include tests for the five member functions that require C++ 23. I've also implemented the new tests in #1024 and tested them using the Kokkos reference <mdspan>.

Signed-off-by: Michael Aziz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants