-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test plan for SYCL_KHR_GROUP_INTERFACE
#1023
base: main
Are you sure you want to change the base?
Add test plan for SYCL_KHR_GROUP_INTERFACE
#1023
Conversation
Signed-off-by: Michael Aziz <[email protected]>
@Pennycook can you review this? I think you're closer to this API than me, so you'd do a better job reviewing the test plan. |
I didn't include any of the C++ 23 member functions in this test plan since I don't have a working implementation of |
Could you use https://github.com/kokkos/mdspan? That's what I've used for |
I'll try using this to add the missing test cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's here so far looks good to me. I've held off on approving to give @0x12CC a chance to experiment with kokkos/mdspan
, as it would be nice to have the C++23 tests in place.
Signed-off-by: Michael Aziz <[email protected]>
@Pennycook, I've updated this test plan to include tests for the five member functions that require C++ 23. I've also implemented the new tests in #1024 and tested them using the Kokkos reference |
Signed-off-by: Michael Aziz <[email protected]>
No description provided.