-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of std::memcmp in bit_cast_test.h #1034
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Hu, Peisen <[email protected]>
Signed-off-by: Hu, Peisen <[email protected]>
I can't find Probably the easiest way is to implement |
Signed-off-by: Hu, Peisen <[email protected]>
Hi Alexey! Thanks for reviewing this. I've fixed the issue as you suggested. Could you please take a look and let me know if it looks good? Thanks! @bader |
Currently, test
sycl_cts/bit_cast_test_core
usesstd::memcmp
which is not guaranteed to be supported under SYCL 2020. Thus replacing it with a helper function that implement the functionality ofstd::memcmp
without linking external library