Louder Windows codesign errors (#4762)

* WIP: Silent failure in signWin.js Fixes #4582 * Temp: force release build * Fake throw * Temp: another test * Clean up for merge
KittyCAD · Jan 3, 2025 · 3695723 · 3695723
1 parent da9cae9
commit 3695723
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/electron-builder.yml b/electron-builder.yml
@@ -38,7 +38,7 @@ win:
     #     - arm64
   signingHashAlgorithms:
     - sha256
-  sign: "./sign-win.js"
+  sign: "./scripts/sign-win.js"
   publisherName: "KittyCAD Inc" # needs to be exactly like on Digicert
   icon: "assets/icon.ico"
   fileAssociations:

diff --git a/sign-win.js → scripts/sign-win.js b/sign-win.js → scripts/sign-win.js
@@ -24,15 +24,14 @@ exports.default = async (configuration) => {
 
   try {
     execSync(
-      `smctl sign --fingerprint="${
-        process.env.WINDOWS_CERTIFICATE_THUMBPRINT
+      `smctl sign --fingerprint="${process.env.WINDOWS_CERTIFICATE_THUMBPRINT
       }" --input "${String(configuration.path)}"`,
       {
         stdio: 'inherit',
       }
     )
     console.log('Signing using signWin.js script: successful')
   } catch (error) {
-    console.error('Signing using signWin.js script: failed:', error)
+    throw new Error('Signing using signWin.js script: failed:', error)
   }
 }