Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove backwards compatibility for snake case in objects #4920

Merged
merged 1 commit into from
Jan 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/wasm-lib/kcl/src/std/helix.rs
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ pub struct HelixData {
/// Number of revolutions.
pub revolutions: f64,
/// Start angle (in degrees).
#[serde(rename = "angleStart", alias = "angle_start")]
#[serde(rename = "angleStart")]
pub angle_start: f64,
/// Is the helix rotation counter clockwise?
/// The default is `false`.
Expand Down
10 changes: 5 additions & 5 deletions src/wasm-lib/kcl/src/std/sketch.rs
Original file line number Diff line number Diff line change
Expand Up @@ -938,13 +938,13 @@ pub enum PlaneData {
/// Origin of the plane.
origin: Box<Point3d>,
/// What should the plane’s X axis be?
#[serde(rename = "xAxis", alias = "x_axis")]
#[serde(rename = "xAxis")]
x_axis: Box<Point3d>,
/// What should the plane’s Y axis be?
#[serde(rename = "yAxis", alias = "y_axis")]
#[serde(rename = "yAxis")]
y_axis: Box<Point3d>,
/// The z-axis (normal).
#[serde(rename = "zAxis", alias = "z_axis")]
#[serde(rename = "zAxis")]
z_axis: Box<Point3d>,
},
}
Expand Down Expand Up @@ -1473,11 +1473,11 @@ pub enum ArcData {
/// Angles and radius with an optional tag.
AnglesAndRadius {
/// The start angle.
#[serde(rename = "angleStart", alias = "angle_start")]
#[serde(rename = "angleStart")]
#[schemars(range(min = -360.0, max = 360.0))]
angle_start: f64,
/// The end angle.
#[serde(rename = "angleEnd", alias = "angle_end")]
#[serde(rename = "angleEnd")]
#[schemars(range(min = -360.0, max = 360.0))]
angle_end: f64,
/// The radius.
Expand Down
Loading