Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix suggestion for updating function decl syntax for anon functions #5088

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

nrc
Copy link
Contributor

@nrc nrc commented Jan 16, 2025

This addresses part 3 of #5081 by adding a separate suggestion for inserting the missing fn, this is not perfect, ideally it would be one suggestion, but that would be a fair bit more work.

@nrc nrc requested a review from adamchalmers January 16, 2025 21:03
Copy link

qa-wolf bot commented Jan 16, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jan 20, 2025 6:36pm

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.09%. Comparing base (9a537da) to head (7dfa2e4).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5088   +/-   ##
=======================================
  Coverage   86.09%   86.09%           
=======================================
  Files          89       89           
  Lines       32389    32399   +10     
=======================================
+ Hits        27884    27894   +10     
  Misses       4505     4505           
Flag Coverage Δ
wasm-lib 86.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jtran jtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nrc nrc merged commit a022b8e into main Jan 21, 2025
33 checks passed
@nrc nrc deleted the nrc-suggest-fn branch January 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants