-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch Export #1140
Batch Export #1140
Conversation
full export only, IMO
Yep
Yes
Out of scope, IMO. We don't support this now and shouldn't add it. The thing it would download is almost certainly not what the user wants.
Yeah, just change the params of the existing one to accept an array, good call. I don't even think you need to rename it. |
I still believe that we need to have separate endpoints for exporting a single dataset vs multiple. Mostly because I like the clarity of I think in implementation I would modify the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's another small edge case:
Batch export for clones where the source media is missing will now fail in a confusing/unclear way.
Before, if you tried to export a dataset where the clone chain is broken it looked like this.
But bulk export will let you include a broken clone (expected). I think the resulting ZIP needs to have a "failures.txt" file or the failed dataset's folder needs to have a placeholder file that says what happened If you have a better idea, that's cool too.
50aa602
to
5938eaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works perfectly.
One nit to remove some dead code.
exportTargetId() { | ||
return this.exportTarget?._id || null; | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was the last reference of exportTarget
, so that can be removed as well.
* templating batch export * initial adding of batch download features * making clear why not using testCharacters * fix linting * minor fixes * mend * fixing failed data * addressing comments and adding in tests * removing last exportTarget reference
fixes #812
fixes #925
Updated 20220131:
GET dive_annotation/{id}/export
for an endpointGET dive_annotation/export
where an array offolderIds
is passed in. Endpoint will now load the multiple folders and pass them to an updatedexport_datasets_zipstream
. If there are multiple folders it names the outputbatch_export.zip
if not it will use the single folder's name.export_datasets_zipstream
toexport_datasets_zipstream
to support multiple girder folders. It will then use the settings and zip up the multiple folders instead of a single folder. Just a minor restructuring of the function to support multiple datasets.platform/web-girder/views/Export.vue
will now take in an array of folderIds instead of a single one.singleDatasetId
for multiple datasets there is only the option to export everything.testCharacters
user because the names of the exported files don't match-up properly.