-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attribute Sorting/Filtering/Graphing #1280
Conversation
const cameraStore = useCameraStore(); | ||
const activeSettings = ref(true); | ||
const sortingMethods = ['a-z', '1-0']; | ||
const sortingMethodIcons = ['mdi-sort-alphabetical-ascending', 'mdi-sort-numeric-ascending']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect to be able to toggle ascending/descending for both of these sorts not switch between sort types. I think this is fine for now because space is an issue but we might want to log an issue for the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied the behavior in the type list. It has the same sort of sorting. Alphabetically or Numerically by count. I wanted to stick with the same paradigm for this.
Co-authored-by: Mary Salvi <[email protected]>
…ttributes-filtering
Change "Key Filter" for the timeline to "Timeline Filter". |
Change "Filter Type" to some terminology which isn't already used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
Couple of thoughts that I don't know if they should be for this PR or another:
I think that when you click on the filter button for either track or detection, the radio button selected should reflect whichever you clicked to open it.
Also I think 'Draw Timeline' should trigger the timeline to switch to the attributes linechart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome!
Attributes Filter/Sorting:
New Features:
Dev Information:
useAttributeFilters
to the provies.ts to use the specific values associated with AttributesFiltering and visualization.