-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LIS3DH and I2C support to LIS2DW #6715
Conversation
b959ae9
to
c330d44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. In general it seems useful. I have some comments - see below.
I don't own a lis2dw sensor, so I can't help with testing.
Note that @nefelim4ag is working on i2c error handling in PR #6689, and I think this PR should come after that work.
Cheers,
-Kevin
c0cc837
to
6e75cba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Looks fine to me. As before, I think this should wait until after #6689.
-Kevin
I’ll await for that change to get merged before refactoring and reaching out to the community for testers. |
FYI, #6689 was merged. -Kevin |
This should be ready to request testers. I am not too worried about testing the lis2dw over I2C, as long as the other three possibilities get tested. |
Whoops, was scrolling and closed by accident. |
Signed-off-by: Luke Vuksta <[email protected]>
Signed-off-by: Luke Vuksta <[email protected]>
Signed-off-by: Luke Vuksta <[email protected]>
Signed-off-by: Luke Vuksta <[email protected]>
Thanks to @dmbutyugin, the LIS3DH has been confirmed to work over SPI! Once I have a regression tester for the LIS2DW over SPI, I believe all branches would be covered by manual tests, and this would be safe to merge. |
Thanks to @Kcdc3d, the LIS2DW has been tested over SPI! @KevinOConnor this should be safe to merge. |
Thanks. -Kevin |
This adds the LIS3DH accelerometer, and brings support for I2C to the LIS2DW. This branch also contains a documentation commit for these changes, a commit allowing the hardware I2C speed on atsamd chips to achieve fast-mode, and an addition to the sample configuration for the Duet3D 1LC. I am personally only able to test the LIS3DH over I2C.
Actions required:
Previous PRs related to this functionality: #6638 #6477
Tagging @KevinOConnor for possible LIS2DW regression testing, @dmbutyugin for possible LIS3DH SPI testing, and @eamaclean for the atsamd change.