Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMC_Driver docs: More info for OverTemp error #6743

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Hello1024
Copy link

Add info useful to advanced users on other ways to deal with overtemp errors.

A few extra suggestions for basic solutions too.

Remove the suggestion to cool motors more (this error is specifically about the controllers, and will not be triggered by a motor overheat)

Add info useful to advanced users on other ways to deal with overtemp errors.

A few extra suggestions for basic solutions too.

Remove the suggestion to cool motors more (this error is specifically about the controllers, and will not be triggered by a motor overheat)
@Sineos
Copy link
Collaborator

Sineos commented Nov 19, 2024

TBH, I would be leery of such advice.

  1. Typical OT errors are pretty rare in my experience.
  2. On a well-built system, there should be no need to adjust these TMC registers.
  3. Sentences like "Advanced users might want to..." are read as: I definitely have to mess with them to fix something with a completely different root cause, and I have no idea what they mean.
  4. Playing with these registers often does more harm than good, as the documentation and dependencies on other settings are not fully transparent.

Please be also aware that you need to sign off to accept the developer certificate of origin, please see point 3 in master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

@dewi-ny-je
Copy link

Wouldn't advanced users already know that?

Copy link

github-actions bot commented Dec 3, 2024

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
    If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants