-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sort by date and reverse order sorting to vsdlist lcd menu item. #6751
base: master
Are you sure you want to change the base?
Conversation
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
f09f6a3
to
7794d33
Compare
reworked the commit, hope it is ok now. thanks. |
7794d33
to
4e15a4f
Compare
This adds two config directives for sorting vsdlist (sd card file list) on a LCD connected to the printer (dumb character display). Add "sort_by_date: True" to a vsdlist menu config to have the files sorted by date chronologically. If not present or "False" then files will be sorted alphabetically just as before. Add "sort_reverse: True" to a vsdlist menu config to have the files sorted in reverse order (descending). If not present or "False" then the files will be sorted in ascending order just as before. By setting both "sort_by_date" and "sort_reverse" to "True" files will be sorted in reverse chronological order (newest first). Please note the file timestamp (date) is taken from the filesystem and some filesystems may have broken timestamps on subsequent writes. Signed-off-by: Dragos Galalae <gala 'underline' dragos 'at' yahoo 'dot' com>
4e15a4f
to
c3a5e95
Compare
any updates on this ? |
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
This adds two config directives for sorting vsdlist (sd card file list) on a LCD connected to the printer (dumb character display).
I've seen this asked around the web, got it working on my klipper installation.
Now you can add "sort_reverse" and "sort_by_date" to a menu config and have the files sorted by date or alphabetically, also in reverse.
Example config: