-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow more control of compiled sensors and displays and features #6763
base: master
Are you sure you want to change the base?
Allow more control of compiled sensors and displays and features #6763
Conversation
the builds fail e.g. with:
Context: I use a atmega328p + st7920 (Full Graphic Smart Controller) as a display and its imposible to build the current master with out size reduction for this setup. |
Thank you for submitting a PR, please be aware that you need to sign off to accept the developer certificate of origin, please see point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review Thanks |
0c61ec3
to
88b37bf
Compare
added Signed-off-by to commit |
Thanks. In general it seems fine to me. There were some recent changes to the Kconfig file (doing something similar) so this PR will need to be rebased to the latest code. Also, at a quick glance it seems this patch misses the conversion of Cheers, |
This Helps to get the size down e.g. for usage with atmega328p. Signed-off-by: Markus Sattler <[email protected]>
88b37bf
to
d427226
Compare
7f94a1b
to
ce8780c
Compare
Thanks. In general it seems fine. However, I don't think we should organize the menu by "support for i2c" and "support for spi". I think we should keep the accelerometers together, the high speed adcs together, the displays together, etc. . That is, I think most users will find an orientation by chip type (not chip interface) to be more convenient. Also, it looks like you introduce a duplicate Also, it doesn't make sense to add Cheers, |
the problme with this is that the chips require I2C / SPI which basicly forces you to decide on that first. if we sort it diffently its hard to under stand why options are simingly randomly there and not. |
Signed-off-by: Links2004 <[email protected]>
ce8780c
to
6ce09c2
Compare
Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html There are some steps that you can take now:
Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available. Best regards, PS: I'm just an automated script, not a human being. |
Thanks. I agree that sorting by sensor type could be confusing when spi/i2c are disabled. However, I think sorting by spi/i2c could also cause confusion. I think I'd prefer to keep the current sorting by sensor type. -Kevin |
This Helps to get the size down e.g. for usage with atmega328p.