Limitation when using the TwigRenderer from elsewhere than a Twig template #1
Labels
Comments
|
Fixed by ef1f547 |
raziel057
added a commit
to raziel057/KnpMenu
that referenced
this issue
May 24, 2022
Currently when creating a RecursiveItemIterator passing a new ArrayIterator, the Iterator is indexed by int.
```php
$treeIterator = new \RecursiveIteratorIterator(
new RecursiveItemIterator(
new \ArrayIterator(array($menu))
), \RecursiveIteratorIterator::SELF_FIRST
);
```
So we got the following error:
Parameter KnpLabs#1 $iterator of class Knp\Menu\Iterator\RecursiveItemIterator constructor expects
Traversable<string, Knp\Menu\ItemInterface>, ArrayIterator<int, Knp\Menu\ItemInterface> given.
I can notice that the typehint in CurrentItemFilterIterator is ok:
https://github.com/KnpLabs/KnpMenu/blob/master/src/Knp/Menu/Iterator/CurrentItemFilterIterator.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Due to the way Twig works, the initRuntime method is only called the first time we load a template. So when using the renderer from elsewhere than a Twig template, we need to initialize it manually (as documented)
Passing the environment to the TwigRenderer when creating it would be the solution but it is impossible currently as it would create a circular dependency. We would need to remove the need to have it as a Twig extension to do this.
https://github.com/fabpot/Twig/issues/429 would allow getting rid of this need if it is implemented. But it would mean than (the yet-to-be-released) Twig 1.2 (assuming it is added in 1.2) will become a requirement, which is an issue for Symfony2 until it becomes the release (not an issue for Silex as it already requires using the master branch)
The text was updated successfully, but these errors were encountered: