Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ci tests for php 8.3 #460

Merged
merged 1 commit into from
Feb 17, 2024
Merged

chore: add ci tests for php 8.3 #460

merged 1 commit into from
Feb 17, 2024

Conversation

Chris53897
Copy link
Contributor

No description provided.

Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Dev deps" should test against php 8.3 as well

@Chris53897
Copy link
Contributor Author

@garak You want this to be changed to 8.3 (see new commit) or additional "Dev deps" tests to 8.2?

Copy link
Collaborator

@garak garak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Chris53897
it seems you need to find a PHPUnit configuration compatible with both 9.6 and 10.0 PHPUnit versions.

@Chris53897
Copy link
Contributor Author

I am not sure if this is possible.

Possible solutions
a) two seperate xml-files
b) stick with phpunit 9
c) Just ignore/silence the deprecation warning (preferred by me)
...

I suggest that the error should be fixed upfront. I am not sure if it is already fixed.

@garak
Copy link
Collaborator

garak commented Oct 13, 2023

Let's go with the solution you prefer.
Anytime soon we'll drop support for PHP 8.0 (which will be EOL before the end of the year), so we'll be able to require PHPUnit 10 only and remove the workaround.

@Chris53897
Copy link
Contributor Author

Sorry for late response. I forgot about this PR

@garak garak merged commit 8107f67 into KnpLabs:master Feb 17, 2024
10 checks passed
@Chris53897 Chris53897 deleted the feature/add-ci-tests-for-php-83 branch February 17, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants