Fix/rust edition 2021 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akerouanton
reviewed
Mar 8, 2022
akerouanton
approved these changes
Mar 8, 2022
Initially, the sources were splitted in many packages to speed up compilation (see #2 ). This has lead to difficulties to navigate through the source code, and created complexity in managing version bumps due to many Cargo.toml files. This commit organizes back the structure of the code under the `src` dir, and bumps rust edition from 2018 to 2021 which would avoid long re-compilations, which were the cause of the initial split.
due to the previous commit, all tests are now ran with the same command
nm2107
force-pushed
the
fix/rust-edition-2021
branch
from
ffb2b91 to
7e793b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, the sources were splitted in many packages to speed up
compilation (see #2 ).
This has lead to difficulties to navigate through the source code, and
created complexity in managing version bumps due to many Cargo.toml
files.
This commit organizes back the structure of the code under the
srcdir, and bumps rust edition from 2018 to 2021 which would avoid long
re-compilations, which were the cause of the initial split.
Thanks to @akerouanton for pointing this out !
Also, this PR updates the test runner, as both unit and functional tests are now ran with the same command.