Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] update deps #38

Merged
merged 2 commits into from
Aug 22, 2024
Merged

[RFR] update deps #38

merged 2 commits into from
Aug 22, 2024

Conversation

nm2107
Copy link
Collaborator

@nm2107 nm2107 commented Aug 21, 2024

  • update rust to the latest version (1.80.1)
  • remove structopt depedency and only use clap instead as structopt was relying on clap anyway, and the structopt features are now included in clap since clap v3 (structopt has entered maintenance mode / end of life).

The release target binary size has been reduced from 607K to 587K.

The next dependency update would be to switch the rust edition from "2021" to "2024" when it will be supported (starting in october if all goes well).

@nm2107 nm2107 requested review from jaljo and alexpozzi August 21, 2024 22:29
- update rust to the latest version (1.80.1)
- remove structopt depedency and only use clap instead as structopt was
  relying on clap anyway, and the structopt features are now included in
  clap since clap v3 (structopt has entered maintenance mode / end of life).

The `release` target binary size has been reduced from 607K to 587K.

The next dependency update would be to switch the rust edition from "2021" to
"2024" when it will be supported (starting in october if all goes well).
@nm2107 nm2107 force-pushed the feat/update-deps branch 2 times, most recently from 8c58292 to df6a86b Compare August 21, 2024 22:52
- update machine version (the previous one was deprecated, see
https://discuss.circleci.com/t/linux-image-deprecations-and-eol-for-2024/50177 )
Copy link
Member

@alexpozzi alexpozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nm2107 nm2107 merged commit 805eec2 into master Aug 22, 2024
2 checks passed
@nm2107 nm2107 deleted the feat/update-deps branch August 22, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants