Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] prepare release v0.3.0 #43

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[RFR] prepare release v0.3.0 #43

merged 1 commit into from
Sep 5, 2024

Conversation

nm2107
Copy link
Collaborator

@nm2107 nm2107 commented Sep 3, 2024

TODO :

  • update release date in the CHANGELOG when this PR is about to be merged.

@nm2107 nm2107 requested review from jaljo and alexpozzi September 3, 2024 19:46
CHANGELOG.md Outdated
Comment on lines 57 to 61
- Update documentation about circleci example ([#29](https://github.com/KnpLabs/should-skip-ci/pull/29)).
- Update documentation about circleci exemple ([#29](https://github.com/KnpLabs/should-skip-ci/pull/29)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure about this change?

CHANGELOG.md Outdated
A new `--base-ref` CLI arg has been introduced in order to compare a specific
tag or commit.

Note that this change as introduced changes to the signature of the
[`should_skip_ci` function](/src/lib.rs).

### Documentation updates

- update CircleCI doc exemple considering CircleCI deprecations ([#41](https://github.com/KnpLabs/should-skip-ci/pull/41)).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- update CircleCI doc exemple considering CircleCI deprecations ([#41](https://github.com/KnpLabs/should-skip-ci/pull/41)).
- update CircleCI doc example considering CircleCI deprecations ([#41](https://github.com/KnpLabs/should-skip-ci/pull/41)).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed 🇫🇷 ^^

thank you 👍

@nm2107 nm2107 merged commit b33c004 into master Sep 5, 2024
2 checks passed
@nm2107 nm2107 deleted the release/v0.3.0 branch September 5, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants