feat: inso collection runner #7700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jackkav
force-pushed
the
feature/ins-4143-basic-collection-runner
branch
from
6083765
to
db642a8
Compare
ihexxa
approved these changes
Jul 17, 2024
| const options = { | ||
| reporter: defaultReporter, | ||
| ...__configFile?.options || {}, | ||
| ...commandOptions, |
There was a problem hiding this comment.
nit: just double check that command options will be overridden by the config file? Original I thought command options might have highest priority.
| return process.exit(1); | ||
| } | ||
|
|
||
| const db = await loadDb({ |
There was a problem hiding this comment.
Probably we could be a bit defensive here and check loadDb failure.
There was a problem hiding this comment.
I agree the db load logic is over complex I'm thinking of a better way to abstract it. Will follow up with a pr soon
| logger.log(`Running request: ${req.name} ${req._id}`); | ||
| const res = await sendRequest(req._id); | ||
| logger.trace(res); | ||
| if (res.status !== 200) { |
There was a problem hiding this comment.
nit: Just a todo item that we might check test results to decide if it is failed in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inso run collectionfuture work
thoughts