fix(Git): issue with including unit-tests and protofiles #8095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we also need to deal with |
Good one also added websocket payload. Looking at the models one by one atm but let me know if you find any other model I haven't caught |
filfreire
approved these changes
Oct 17, 2024
filfreire
force-pushed
the
fix/nedbclient-filters
branch
from
87319c1
to
fb76757
Compare
yaoweiprc
reviewed
Oct 18, 2024
| const modelTypesWithinFolders = [models.request.type, models.grpcRequest.type, models.webSocketRequest.type]; | ||
| const typeFilter = modelTypesWithinFolders.includes(type) ? [models.requestGroup.type, type] : [type]; | ||
| if (modelTypesWithinFolders.includes(type)) { |
There was a problem hiding this comment.
If we want to get all requests in a workspace, It's unintuitive that we need to pass [requestGroup, request] as the queryTypes argument to withDescendants and then filter out the requestGroups from result. Maybe we can do it within withDescendants method.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlihts: