Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-scrolling to selected navigation item on page load #2575

Merged
merged 3 commits into from
Jul 26, 2022
Merged

Add auto-scrolling to selected navigation item on page load #2575

merged 3 commits into from
Jul 26, 2022

Conversation

IgnatBeresnev
Copy link
Member

@IgnatBeresnev IgnatBeresnev commented Jul 20, 2022 •
edited
Loading

See #2576

@IgnatBeresnev IgnatBeresnev requested a review from vmishenev July 20, 2022 22:45
@IgnatBeresnev IgnatBeresnev mentioned this pull request Jul 20, 2022
Closed
vmishenev
vmishenev reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@vmishenev vmishenev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I open a main page where there is not selected element
image

@IgnatBeresnev
Copy link
Member Author

Indeed 👍 Fixed

@IgnatBeresnev IgnatBeresnev requested a review from vmishenev July 26, 2022 12:55
@IgnatBeresnev IgnatBeresnev merged commit 838ec1b into master Jul 26, 2022
@IgnatBeresnev IgnatBeresnev deleted the navigation-scrolling branch July 26, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmishenev vmishenev vmishenev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgnatBeresnev @vmishenev