Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to ONNXInferenceModel human-readable model description #368

Closed
zaleslaw opened this issue May 18, 2022 · 0 comments
Closed

Add to ONNXInferenceModel human-readable model description #368

zaleslaw opened this issue May 18, 2022 · 0 comments
Assignees
@ermolenkodev
Labels
enhancement New feature or request
Milestone
0.5

Comments

@zaleslaw
Copy link
Collaborator

The existing toString method just prints some underlying information from the ONNX Java API.

We need to unify the input/output information with the TF module and also add info from modelHub if possible and about the specific type
@zaleslaw zaleslaw added the enhancement New feature or request label May 18, 2022
@zaleslaw zaleslaw added this to the 0.5 milestone May 20, 2022
@ermolenkodev ermolenkodev self-assigned this Oct 20, 2022
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Oct 26, 2022
@ermolenkodev
Add common ModelSummary interface for tensorflow and onnx models (Kot…
7064722 
…lin#368)

* Add interface ModelSummary

* Add OnnxModelSummary
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Oct 26, 2022
@ermolenkodev
Refactor summary functianality to use new ModelSummary interface (Kot…
93d3e0a 
…lin#368)

* GraphTrainableModel summary implements common ModelSummary interface

* TrainableModel, OnnxInferenceModel and All models from ModelHub implement ModelWithSummary interface

* ModelHub models now reveive corresponding ModelType as parameter and this info available in summary
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Oct 26, 2022
@ermolenkodev
Add missing KDocs (Kotlin#368)
49897a3 
* Add Kdocs for public interfaces and methods

* Rename specificType -> type in base classes

* Fix formatting
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Oct 26, 2022
@ermolenkodev
Update tests and examples (Kotlin#368)
f2096b5 
* Add test for OnnxModelSummary

* Add summary logging to examples
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Oct 26, 2022
@ermolenkodev
Minor cleanup (Kotlin#368)
bf7dff2
@ermolenkodev ermolenkodev mentioned this issue Oct 26, 2022
Merged
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Add common ModelSummary interface for tensorflow and onnx models (Kot…
e665070 
…lin#368)

* Add interface ModelSummary

* Add OnnxModelSummary
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Refactor summary functianality to use new ModelSummary interface (Kot…
15fcb46 
…lin#368)

* GraphTrainableModel summary implements common ModelSummary interface

* TrainableModel, OnnxInferenceModel and All models from ModelHub implement ModelWithSummary interface

* ModelHub models now reveive corresponding ModelType as parameter and this info available in summary
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Add missing KDocs (Kotlin#368)
d190d21 
* Add Kdocs for public interfaces and methods

* Rename specificType -> type in base classes

* Fix formatting
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Update tests and examples (Kotlin#368)
f485c8d 
* Add test for OnnxModelSummary

* Add summary logging to examples
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Minor cleanup (Kotlin#368)
fda4ba3
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Refactor summary formatting (Kotlin#368)
4b68318 
* Get rid of code duplication in OnnxModelSummary and TfModelSummary

* Introduce  table Section interface

* Split table creation process and pretty-printing process
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Change modelType field type (Kotlin#368)
4398dd1 
Replace ModelType with String in OnnxHighLevelModel and ImageRecognitionModelBase.

This will allow users with custom models use this property as well.
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 8, 2022
@ermolenkodev
Add passing modelKindDescription to the copy functions (Kotlin#368)
90aa125
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 9, 2022
@ermolenkodev
Refactoring of formatting (Kotlin#368)
e9ac517 
* Introduce Cell to simplify complex TableRow creation

* Refactoring alignment of section to not modify internal of Section model

* Minor fixes
ermolenkodev added a commit to ermolenkodev/KotlinDL that referenced this issue Nov 14, 2022
@ermolenkodev @juliabeliaeva
Refactoring of formatting (Kotlin#368)
36d5b72 
* Introduce Cell to simplify complex TableRow creation

* Refactoring alignment of section to not modify internal of Section model

* Minor fixes

Co-authored-by: Julia Beliaeva <[email protected]>
ermolenkodev added a commit that referenced this issue Nov 15, 2022
@ermolenkodev @juliabeliaeva
Unified summary printing for Tensorflow and ONNX models (#475)
16fcb34 
* Add common ModelSummary interface for TensorFlow and onnx models (#368)

* Add interface ModelSummary

* Add OnnxModelSummary

* Refactor summary functionality to use the new ModelSummary interface (#368)

* GraphTrainableModel summary implements common ModelSummary interface

* TrainableModel, OnnxInferenceModel, and All models from ModelHub implement the ModelWithSummary interface

* ModelHub models now receive the corresponding ModelType as a parameter, and this info available in summary

* Add missing KDocs (#368)

* Add Kdocs for public interfaces and methods

* Rename specificType -> type in base classes

* Fix formatting

* Update tests and examples (#368)

* Add test for OnnxModelSummary

* Add summary logging to examples

* Minor cleanup (#368)

* Refactor summary formatting (#368)

* Get rid of code duplication in OnnxModelSummary and TfModelSummary

* Introduce  table Section interface

* Split table creation process and pretty-printing process

* Change modelType field type (#368)

Replace ModelType with String in OnnxHighLevelModel and ImageRecognitionModelBase.

This will allow users with custom models to use this property as well.

* Add passing modelKindDescription to the copy functions (#368)

* Refactoring of formatting (#368)

* Introduce Cell to simplify complex TableRow creation

* Refactor alignment of the section not to modify the internals of the Section model

* Minor fixes

Co-authored-by: Julia Beliaeva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ermolenkodev ermolenkodev

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@zaleslaw @ermolenkodev