Add model output type checks for OnnxInferenceModel (#285) #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ermolenkodev
commented
Apr 18, 2022
ermolenkodev
commented
|
It's not an actual fix of #285 but temporary solution to facilitate releasing of 0.4. Later we will implement support of ONNX output types such as Sequence and Map |
juliabeliaeva
suggested changes
Apr 18, 2022
onnx/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/OnnxInferenceModel.kt
Outdated
Show resolved
Hide resolved
onnx/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/OnnxInferenceModel.kt
Outdated
Show resolved
Hide resolved
onnx/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/OnnxInferenceModel.kt
Outdated
Show resolved
Hide resolved
onnx/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/OnnxInferenceModel.kt
Outdated
Show resolved
Hide resolved
onnx/src/main/kotlin/org/jetbrains/kotlinx/dl/api/inference/onnx/OnnxInferenceModel.kt
Show resolved
Hide resolved
* If model output type not supported exception will be thrown
* Exception message contains recommendation to use predictRaw() method
* Add test demonstrating usage of onnx model with unsupported output type
* Minor changes after apply of auto-format
juliabeliaeva
approved these changes
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.