-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix layers import and export #360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaleslaw
reviewed
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's clarify some details regarding test naming
api/src/main/kotlin/org/jetbrains/kotlinx/dl/api/core/util/ContainerUtil.kt
Outdated
Show resolved
Hide resolved
...test/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ActivationLayersImportExportTest.kt
Outdated
Show resolved
Hide resolved
...t/kotlin/org/jetbrains/kotlinx/dl/api/inference/keras/ConvolutionalLayersImportExportTest.kt
Outdated
Show resolved
Hide resolved
val input = +Input(10) | ||
val dense1 = +Dense(name = "Dense1", outputSize = 5)(input) | ||
val dense2 = +Dense(name = "Dense2", outputSize = 5)(input) | ||
+Dot(name = "test_dot", axis = intArrayOf(1, 1), normalize = true)(dense1, dense2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice tests!
juliabeliaeva
force-pushed
the
keras-export
branch
from
April 24, 2022 16:59
00d9ba8
to
08ebcb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various issues with importing and exporting layers configuration and adds missing weights import for
Conv1D
,Conv3D
andPReLU
layers. This is a step towards addressing #89.