Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layers import and export #360

Merged
merged 17 commits into from
Apr 25, 2022
Merged

Conversation

juliabeliaeva
Copy link
Contributor

@juliabeliaeva juliabeliaeva commented Apr 22, 2022

This PR fixes various issues with importing and exporting layers configuration and adds missing weights import for Conv1D, Conv3D and PReLU layers. This is a step towards addressing #89.

Copy link
Collaborator

@zaleslaw zaleslaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's clarify some details regarding test naming

val input = +Input(10)
val dense1 = +Dense(name = "Dense1", outputSize = 5)(input)
val dense2 = +Dense(name = "Dense2", outputSize = 5)(input)
+Dot(name = "test_dot", axis = intArrayOf(1, 1), normalize = true)(dense1, dense2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@juliabeliaeva juliabeliaeva merged commit d21ea93 into Kotlin:master Apr 25, 2022
@juliabeliaeva juliabeliaeva deleted the keras-export branch April 26, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants