Create all necessary parent directories when saving models #534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @juliabeliaeva I will check your PR and write the answer |
zaleslaw
reviewed
Apr 19, 2023
| @@ -825,20 +825,17 @@ public abstract class GraphTrainableModel(vararg layers: Layer) : TrainableModel | |||
| when (writingMode) { | |||
| WritingMode.FAIL_IF_EXISTS -> { | |||
| check(!modelDirectory.exists()) { "The directory exists on path $pathToModelDirectory, please be careful it could contain valuable model! Change this mode to OVERRIDE if you want to override this directory." } | |||
| Files.createDirectories(modelDirectory.toPath()) | |||
There was a problem hiding this comment.
I need to say, that this is not the same code with replacement of createDirectories + mkdir => mkdirs due to reducing number of checks and supported exceptions
But I agree, it should be consistent in both files
There was a problem hiding this comment.
I can replace mkdirs with Files.createDirectories if you think it's a better fit (but I don't think we need both).
There was a problem hiding this comment.
Wow, really, double creation of the last directory, ok, I will check and return
zaleslaw
approved these changes
Apr 19, 2023
Use NIO to create directories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #525