Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the ticker channel example giving wrong results on the website #4109

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

dkhalanskyjb
Copy link
Collaborator

https://play.kotlinlang.org/ of the example that's being changed here is currently unreliable: the last line is occasionally null.

By increasing all time intervals twofold, we reduce the impact of the CPU scheduling in the constrained environment. With this change, the results are consistent across dozens of runs: https://pl.kotl.in/uCa-60j43

Originally reported by @PetrakovichVictoria

@dkhalanskyjb dkhalanskyjb requested a review from qwwdfsad April 22, 2024 12:57
@qwwdfsad
Copy link
Member

knitCheck fails

https://play.kotlinlang.org/ of the example that's being changed
here is currently unreliable: the last line is occasionally `null`.

By increasing all time intervals twofold, we reduce the impact of
the CPU scheduling in the constrained environment. With this
change, the results are consistent across dozens of runs:
<https://pl.kotl.in/uCa-60j43>

Originally reported by `@PetrakovichVictoria`
@dkhalanskyjb dkhalanskyjb force-pushed the dk-fix-ticker-channel-example branch from 7c726b1 to dbaa89d Compare April 23, 2024 09:35
@dkhalanskyjb dkhalanskyjb requested review from qwwdfsad and removed request for qwwdfsad April 23, 2024 10:54
@dkhalanskyjb dkhalanskyjb merged commit c1ba5af into master Apr 25, 2024
1 check passed
@dkhalanskyjb dkhalanskyjb deleted the dk-fix-ticker-channel-example branch April 25, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants