Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEMApplication] Fixed some bugs and added a smooth-joint model #11323

Merged
merged 37 commits into from
Sep 24, 2023

Conversation

ChengshunShang1996
Copy link
Member

@ChengshunShang1996 ChengshunShang1996 commented Jun 27, 2023

📝 Description
For the constitutive laws, some bugs were fixed and a smooth-joint model was established in Kratos DEMApplicaiton.
For the post-processing part, the 'VtkOutput' class was expanded for exporting more particle variables and contact variables.

🆕 Changelog

  • Added a BoundingBox moving method for applying force with periodic boundary.
  • Added a global viscous damping force for simulating quasi-static problem.
  • Fixed the bug of the viscous damping force calculation for the unbonded part in ParallelBondModelCL.
  • Fixed a bug related to the periodic boundary.
  • Added a smooth-joint model for joint simulation in geomaterial.
  • Added a void model for particle contact, as its name, no force will be calculated when we apply this model to a group of particles.

joints2

  • Expanded the .vtk output class to more particle variables.
  • Expanded the .vtk output class to contact variables, which could be very useful to display force chains.

paraview_contact

@maceligueta
Copy link
Member

In order to ensure that any feature does not break with future changes, we should add tests for every new feature, with small cases (they must run fast). For the moving BB and the smooth-joint model, for example, we/you need to make sure nobody breaks them with apparently independent changes.

@ChengshunShang1996
Copy link
Member Author

In order to ensure that any feature does not break with future changes, we should add tests for every new feature, with small cases (they must run fast). For the moving BB and the smooth-joint model, for example, we/you need to make sure nobody breaks them with apparently independent changes.

Get it!

@ChengshunShang1996
Copy link
Member Author

Please help me review the PR. Thanks! @KratosMultiphysics/dem

@salvalatorre
Copy link
Member

It's a fairly big PR... Anyway, if you had the corresponding tests implemented and they work fine, I don't see any objection in approving this once the Codacy SCA is successful... ;)

@salvalatorre
Copy link
Member

Oh, only Codacy errors with severity higher or equal to medium, don't worry about minors :)

@ChengshunShang1996
Copy link
Member Author

It's a fairly big PR... Anyway, if you had the corresponding tests implemented and they work fine, I don't see any objection in approving this once the Codacy SCA is successful... ;)

At the beginning, it's a small one. But, it grown up day by day :). The corresponding tests has been implemented and work good.

@ChengshunShang1996
Copy link
Member Author

Oh, only Codacy errors with severity higher or equal to medium, don't worry about minors :)

The Codacy analysis errors seem mainly because of the using of C++ function in Python part. I tried to improve them but I didn't find a proper way to make it. If anyone could give me some advice on it, I will appreciate it.

Copy link
Member

@salvalatorre salvalatorre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will discuss a bit about Codacy, not a big issue at all...

@ChengshunShang1996 ChengshunShang1996 merged commit a635aa3 into master Sep 24, 2023
@ChengshunShang1996 ChengshunShang1996 deleted the dem/bonded_particle_model branch September 24, 2023 16:57
@ChengshunShang1996 ChengshunShang1996 restored the dem/bonded_particle_model branch September 24, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants