-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEMApplication] Fixed some bugs and added a smooth-joint model #11323
Conversation
In order to ensure that any feature does not break with future changes, we should add tests for every new feature, with small cases (they must run fast). For the moving BB and the smooth-joint model, for example, we/you need to make sure nobody breaks them with apparently independent changes. |
Get it! |
…Multiphysics/Kratos into dem/bonded_particle_model
Please help me review the PR. Thanks! @KratosMultiphysics/dem |
It's a fairly big PR... Anyway, if you had the corresponding tests implemented and they work fine, I don't see any objection in approving this once the Codacy SCA is successful... ;) |
Oh, only Codacy errors with severity higher or equal to medium, don't worry about minors :) |
At the beginning, it's a small one. But, it grown up day by day :). The corresponding tests has been implemented and work good. |
The Codacy analysis errors seem mainly because of the using of C++ function in Python part. I tried to improve them but I didn't find a proper way to make it. If anyone could give me some advice on it, I will appreciate it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will discuss a bit about Codacy, not a big issue at all...
📝 Description
For the constitutive laws, some bugs were fixed and a smooth-joint model was established in Kratos DEMApplicaiton.
For the post-processing part, the 'VtkOutput' class was expanded for exporting more particle variables and contact variables.
🆕 Changelog