Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] More code smells resolved on custom_constitutive #11516

Merged
merged 1 commit into from
Aug 29, 2023
Merged

[GeoMechanicsApplication] More code smells resolved on custom_constitutive #11516

merged 1 commit into from
Aug 29, 2023

Conversation

WPK4FEM
Copy link
Contributor

@WPK4FEM WPK4FEM commented Aug 28, 2023

📝 Description
More code smells removed

🆕 Changelog
-Complexity
-make_shared

  • ==false replaced by !
  • Hiding of base class member functions
  • const correctness
  • virtual removed i.c.o. override
  • shadowing of X, Y, Z
  • duplication ( GetStateVariableIndex)

@WPK4FEM WPK4FEM added Cleanup Refactor When code is moved or rewrote keeping the same behavior GeoMechanics Issues related to the GeoMechanicsApplication labels Aug 28, 2023
@WPK4FEM WPK4FEM requested a review from avdg81 August 28, 2023 12:29
@WPK4FEM WPK4FEM force-pushed the geo/continued-clean-custom_constitutive branch from c05c965 to b819bf1 Compare August 28, 2023 15:16
@avdg81 avdg81 force-pushed the geo/continued-clean-custom_constitutive branch from b819bf1 to c31970e Compare August 29, 2023 11:22
avdg81
avdg81 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice cleanup!

@WPK4FEM WPK4FEM merged commit 4aa5c9c into master Aug 29, 2023
@WPK4FEM WPK4FEM deleted the geo/continued-clean-custom_constitutive branch August 29, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdg81 avdg81 avdg81 approved these changes

Assignees
No one assigned
Labels
Cleanup GeoMechanics Issues related to the GeoMechanicsApplication Refactor When code is moved or rewrote keeping the same behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WPK4FEM @avdg81