Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsAnalysis] added test for changing waterlevel #11517

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[GeoMechanicsAnalysis] added test for changing waterlevel #11517

merged 1 commit into from
Sep 6, 2023

Conversation

indigocoral
Copy link
Contributor

📝 Description
Test for changing water level in time

🆕 Changelog

  • Added test_column_changing_waterlevel.py

@indigocoral indigocoral added Testing GeoMechanics Issues related to the GeoMechanicsApplication labels Aug 28, 2023
@indigocoral indigocoral requested a review from avdg81 August 28, 2023 12:47
@indigocoral indigocoral force-pushed the geo/test_changing_waterlevel branch 2 times, most recently from 5f00808 to 6d530d3 Compare August 29, 2023 07:50
@indigocoral indigocoral mentioned this pull request Aug 30, 2023
Closed
@indigocoral indigocoral linked an issue Sep 1, 2023 that may be closed by this pull request
[GeoMechanicsApplication] Check weight computation of partially saturated material #11527
Closed
@indigocoral @avdg81
Added a test for changing waterlevel
c75e322 
Also added a general helper function for reading simulation results from
a GiD output file (`.post.res`).
@avdg81 avdg81 force-pushed the geo/test_changing_waterlevel branch from 7822589 to c75e322 Compare September 6, 2023 09:25
avdg81
avdg81 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. The result looks good to me.

@avdg81 avdg81 merged commit 39c04f3 into master Sep 6, 2023
@avdg81 avdg81 deleted the geo/test_changing_waterlevel branch September 6, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avdg81 avdg81 avdg81 approved these changes

Assignees
No one assigned
Labels
GeoMechanics Issues related to the GeoMechanicsApplication Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Check weight computation of partially saturated material
2 participants
@indigocoral @avdg81