Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OptimizationApp] Marking test a expected failure until fixed #11557

Merged
merged 3 commits into from
Sep 14, 2023

Conversation

roigcarlo
Copy link
Member

📝 Description
Marking a problematic test as expected fail until fixed.

@avdg81 @SADPR This should get rid of the failing CI tests.

@sunethwarna I marked it as expected failure until fixed as is holding down several PR.

@sunethwarna
Copy link
Member

Thanks. I'm check it once I'm back

sunethwarna
sunethwarna previously approved these changes Sep 13, 2023
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not fail always RYT?, so I think we need to comment out the test.

@roigcarlo
Copy link
Member Author

O you are right...

@avdg81
Copy link
Contributor

avdg81 commented Sep 13, 2023

📝 Description Marking a problematic test as expected fail until fixed.

@avdg81 @SADPR This should get rid of the failing CI tests.

@sunethwarna I marked it as expected failure until fixed as is holding down several PR.

Thanks for taking action @roigcarlo, really appreciate that. And thanks in advance to @sunethwarna for his willingness to look into the problem.

sunethwarna
sunethwarna previously approved these changes Sep 13, 2023
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roigcarlo

@roigcarlo roigcarlo merged commit af678f2 into master Sep 14, 2023
@roigcarlo roigcarlo deleted the optapp/temp-disable-test branch September 14, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants