Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CompressiblePotentialFlowApp] Adding Line Search Strategy to settings #11575

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[CompressiblePotentialFlowApp] Adding Line Search Strategy to settings #11575

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c02d10
add line search stategy and solving strategy settings
Marco1410 Sep 19, 2023
77d077b
Update potential_flow_solver.py using fluid_solver functions
Marco1410 Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 43 additions & 25 deletions applications/CompressiblePotentialFlowApplication/python_scripts/potential_flow_solver.py
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,14 @@ def GetDefaultParameters(cls):
"echo_level": 0,
"potential_application_echo_level": 0,
"convergence_criterion": "residual_criterion",
"solving_strategy_settings": {
"type" : "newton_raphson",
"advanced_settings" : {}
},
"relative_tolerance": 1e-12,
"absolute_tolerance": 1e-12,
"compute_reactions": false,
"reform_dofs_at_each_step": false,
"calculate_solution_norm": false,
"linear_solver_settings": {
"solver_type": "amgcl"
},
Expand Down Expand Up @@ -270,37 +273,52 @@ def _CreateConvergenceCriterion(self):

def _CreateSolutionStrategy(self):
strategy_type = self._GetStrategyType()
computing_model_part = self.GetComputingModelPart()
time_scheme = self._GetScheme()
linear_solver = self._GetLinearSolver()
builder_and_solver = self._GetBuilderAndSolver()
if strategy_type == "linear":
solution_strategy = KratosMultiphysics.ResidualBasedLinearStrategy(
computing_model_part,
time_scheme,
linear_solver,
builder_and_solver,
self.settings["compute_reactions"].GetBool(),
self.settings["reform_dofs_at_each_step"].GetBool(),
self.settings["calculate_solution_norm"].GetBool(),
self.settings["move_mesh_flag"].GetBool())
solution_strategy = self._CreateLinearStrategy()
elif strategy_type == "non_linear":
convergence_criterion = self._GetConvergenceCriterion()
solution_strategy = KratosMultiphysics.ResidualBasedNewtonRaphsonStrategy(
computing_model_part,
time_scheme,
linear_solver,
convergence_criterion,
builder_and_solver,
self.settings["maximum_iterations"].GetInt(),
self.settings["compute_reactions"].GetBool(),
self.settings["reform_dofs_at_each_step"].GetBool(),
self.settings["move_mesh_flag"].GetBool())
# Create strategy
if self.settings["solving_strategy_settings"]["type"].GetString() == "newton_raphson":
solution_strategy = self._CreateNewtonRaphsonStrategy()
elif self.settings["solving_strategy_settings"]["type"].GetString() == "line_search":
solution_strategy = self._CreateLineSearchStrategy()
else:
err_msg = "Unknown strategy type: \'" + strategy_type + "\'. Valid options are \'linear\' and \'non_linear\'."
raise Exception(err_msg)
return solution_strategy

def _CreateLineSearchStrategy(self):
if self.settings["solving_strategy_settings"].Has("advanced_settings"):
settings = self.settings["solving_strategy_settings"]["advanced_settings"]
settings.AddMissingParameters(self._GetDefaultLineSearchParameters())
else:
settings = self._GetDefaultLineSearchParameters()
settings.AddValue("max_iteration", self.settings["maximum_iterations"])
settings.AddValue("compute_reactions", self.settings["compute_reactions"])
settings.AddValue("reform_dofs_at_each_step", self.settings["reform_dofs_at_each_step"])
settings.AddValue("move_mesh_flag", self.settings["move_mesh_flag"])
computing_model_part = self.GetComputingModelPart()
time_scheme = self._GetScheme()
convergence_criterion = self._GetConvergenceCriterion()
builder_and_solver = self._GetBuilderAndSolver()
solution_strategy = KratosMultiphysics.LineSearchStrategy(computing_model_part,
time_scheme,
convergence_criterion,
builder_and_solver,
settings)
return solution_strategy

@classmethod
def _GetDefaultLineSearchParameters(self):
default_line_search_parameters = KratosMultiphysics.Parameters(r"""{
"max_line_search_iterations" : 5,
"first_alpha_value" : 0.5,
"second_alpha_value" : 1.0,
"min_alpha" : 0.1,
"max_alpha" : 2.0,
"line_search_tolerance" : 0.5
}""")
return default_line_search_parameters

def _SetPhysicalProperties(self):
# There are no properties in the potential flow solver. Free stream quantities are defined in the apply_far_field_process.py
return True