-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Extend IntegrationUtilities to Compute Derivatives #11604
Merged
sunethwarna
merged 5 commits into
master
from
core/integration_utilities/feature/derivatives
Sep 26, 2023
Merged
[Core] Extend IntegrationUtilities to Compute Derivatives #11604
sunethwarna
merged 5 commits into
master
from
core/integration_utilities/feature/derivatives
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kratos/tests/cpp_tests/utilities/test_integration_utilities.cpp
Outdated
Show resolved
Hide resolved
kratos/tests/cpp_tests/utilities/test_integration_utilities.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
Co-authored-by: Vicente Mataix Ferrándiz <[email protected]>
loumalouomega
previously approved these changes
Sep 25, 2023
loumalouomega
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay
sunethwarna
deleted the
core/integration_utilities/feature/derivatives
branch
September 26, 2023 06:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR extends to have analytical derivative computations for methods
IntegrationUtilities::ComputeArea2DGeometry
andComputeVolume3DGeometry
namelyIntegrationUtilities::ComputeArea2DGeometryDerivative
andIntegrationUtilities::ComputeVolume3DGeometryDerivative
.This PR is required for #11571 .
PS: I think the whole
IntegrationUtilities
class can be divided into.h
and.cpp
even though there are some inlined methods. @roigcarlo @matekelemen🆕 Changelog
IntegrationUtilities::ComputeArea2DGeometryDerivative
IntegrationUtilities::ComputeVolume3DGeometryDerivative