Adding Inlet/Outlet warning message for twofluid hydraulic solver #11652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbucher
reviewed
Oct 3, 2023
...ications/FluidDynamicsApplication/python_scripts/navier_stokes_two_fluid_hydraulic_solver.py
Outdated
Show resolved
Hide resolved
…okes_two_fluid_hydraulic_solver.py Co-authored-by: Philipp Bucher <[email protected]>
philbucher
reviewed
Oct 4, 2023
| def _HydraulicBoundaryConditionCheck(self,boundary,name): | ||
| # Check if the inlet and outl | ||
| computing_model_part = self.GetComputingModelPart() | ||
| not_boundary_nodes=any([node.Is(boundary) for node in computing_model_part.Nodes]) |
There was a problem hiding this comment.
Suggested change
| not_boundary_nodes=any([node.Is(boundary) for node in computing_model_part.Nodes]) | |
| not_boundary_nodes=not any([node.Is(boundary) for node in computing_model_part.Nodes]) |
I think it should be like this, but please check the logic yourself, I only wanted to point out a potentially smarter way
rubenzorrilla
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Including a warning message to verify if the inlet/outlet boundary conditions are correctly set, as it affects to the calculated theoretical volume of the system.