[GeoMechanicsApplication] Add a time incrementor that models a collection of prescribed time increments #11662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a time step has finished and its result has been processed, we advance the iterator. In this way, when we have a list of N time increments and we process N time step results, the next query whether a next step must be carried out will yield false. Also removed two empty statements.
rfaasse
previously approved these changes
Oct 5, 2023
applications/GeoMechanicsApplication/tests/cpp_tests/test_prescribed_time_incrementor.cpp
Outdated
Show resolved
Hide resolved
applications/GeoMechanicsApplication/custom_workflows/prescribed_time_incrementor.cpp
Show resolved
Hide resolved
- Ensure that a returned value is assigned to a variable when the function is marked `[[nodiscard]]`. - Removed two empty statements.
The unused variable was added to suppress a warning due to the `[[nodiscard]]` attribute of a member function. To avoid another warning due to the unused variable, the dummy variable has now been decorated with the `[[maybe_unused]]` attribute.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Added a time incrementor that implements the time incrementor interface for the case where we have a collection of prescribed time increments. This class is probably one of the simplest (and most fundamental) ways to step through time. We will use it when developing the time loop executor. (But we may consider to also make it accessible through the
ProjectParameters.jsonfile.)